Make use of multi-line logging in latest jat.sh

src/xcase.sh.skel

@@ -603,19 +603,21 @@ __xcase__plan() {
     # Enumerate and validate cases
     #
     local id    # each case id
+    local lines=()  # output lines
     __xcase__has enum || {
         jat__log_error "case ID enumerator handler not implemented: xcase__enum"
         return 3
     }
     xcase__enum > "$__xcase__tmp/enum"
     __xcase__ttl=$(wc -l <"$__xcase__tmp/enum")
-    jat__log_info "enumerated $__xcase__ttl cases:"
-    jat__log_info ""
+    lines+=("enumerated $__xcase__ttl cases:")
+    lines+=("")
     while IFS= read -r id;
     do
-        jat__log_info "    $id"
+        lines+=("    $id")
     done <"$__xcase__tmp/enum"
-    jat__log_info ""
+    lines+=("")
+    jat__log_info "${lines[@]}"
     __xcase__validate_enum || return $?
     test "$__xcase__ttl" -eq 0 && {
         jat__log_error "no cases enumerated, nothing to do"
@@ -682,11 +684,12 @@ __xcase__run_all() {
 
         ((__xcase__n++))
 
-        jat__log_info "  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"
-        jat__log_info " /"
-        jat__log_info "o   $__xcase__n/$__xcase__ttl: $__xcase__id"
-        jat__log_info " \\"
-        jat__log_info '  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~'
+        jat__log_info \
+             "  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" \
+             " /" \
+             "o   $__xcase__n/$__xcase__ttl: $__xcase__id" \
+             " \\" \
+             '  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~'
         echo >&2
 
         __xcase__varcode=$(__xcase__mkvarcode) || {
@@ -812,16 +815,20 @@ __xcase__upload_note() {
     #
     # Provide note about file uploads (if applicable)
     #
+    local items     # of filename list
     local item      # of filename list
+    local lines=()  # output lines
     $__xcase__rball     || return 0
     __xcase__nonempty . || return 0
-    jat__log_info "Items to be auto-collected to xcase-relics.tar.gz:"
+    items=$(__xcase__tmpfile "C.relist")
+    lines+=("Items to be auto-collected to xcase-relics.tar.gz:")
     find . -mindepth 1 -maxdepth 1 -printf "%P\\n" \
-      | sort \
-      | while read -r item;
-        do
-            jat__log_info " *  $item"
-        done
+      | sort >"$items"
+    while read -r item;
+    do
+        lines+=(" *  $item")
+    done <"$items"
+    jat__log_info "${lines[@]}"
     echo >&2
 }
 
@@ -934,7 +941,6 @@ __xcase__summary() {
     #
     # Show summary phase
     #
-    local logfunc       # log function for a row
     local id            # case id
     local r_setup       # handler result: setup
     local r_test        #              ^^ test
@@ -942,12 +948,15 @@ __xcase__summary() {
     local r_cleanup     #              ^^ cleanup
     local hdata         # path to cached handler data
     local num=0         # row number
+    local lines=()      # output lines
     jat__pstartd "xcase summary"
-        jat__log_info "duration: $(__xcase__tstats)"
-        jat__log_info ""
-        jat__log_info "============================================="
-        jat__log_info "setup   test    diag    cleanup | case id";
-        jat__log_info "--------------------------------|------------"
+        lines+=(
+            "duration: $(__xcase__tstats)"
+            ""
+            "============================================="
+            "setup   test    diag    cleanup | case id"
+            "--------------------------------|------------"
+        )
         for id in $(<"$__xcase__tmp/enum");
         do
             ((num++))
@@ -956,21 +965,15 @@ __xcase__summary() {
             r_test=$(<"$hdata/test/result")
             r_diag=$(<"$hdata/diag/result")
             r_cleanup=$(<"$hdata/cleanup/result")
-            case $r_setup:$r_test:$r_diag:$r_cleanup in
-                # internal error or cleanup fail: severe issue
-                *axerr*)    logfunc=jat__log_error ;;
-                *:fail)     logfunc=jat__log_error ;;
-                # else: ok
-                *)          logfunc=jat__log_info ;;
-            esac
-            $logfunc "$(
+            lines+=("$(
                 __xcase__sumrow \
                     "$r_setup" "$r_test" "$r_diag" "$r_cleanup" \
                     "$num" "$(wc -l < "$__xcase__tmp/enum")" \
                     "$id"
-            )"
+            )")
         done
-        jat__log_info "============================================="
+        lines+=("=============================================")
+        jat__log_info "${lines[@]}"
         __xcase__stats
         jat__log_info ""
     jat__pend
@@ -1087,6 +1090,7 @@ __xcase__stats() {
     local tests     # tests       ^^
     local diags     # diags       ^^
     local cleanups  # cleanups    ^^
+    local lines=()  # output lines
     results=$(find "$__xcase__tmp/data/id/" -path "*/handler/*/result" -exec grep -H . {} +)
     for result in pass fail abort axerr;
     do
@@ -1095,8 +1099,9 @@ __xcase__stats() {
         diags=$(grep -c "diag/result:$result$" <<<"$results")
         cleanups=$(grep -c "cleanup/result:$result$" <<<"$results")
         test "$((setups + tests + diags + cleanups))" -eq 0 && continue
-        jat__log_info "$(printf '%-8s%-8s%-8s%-8s| x %s\n' "$setups" "$tests" "$diags" "$cleanups" $result)"
+        lines+=("$(printf '%-8s%-8s%-8s%-8s| x %s\n' "$setups" "$tests" "$diags" "$cleanups" $result)")
     done
+    jat__log_info "${lines[@]}"
 }
 
 __xcase__results() {
@@ -1135,28 +1140,34 @@ __xcase__validate_enum() {
     #
     local allowed='[:alnum:]._,+%=-'    # allowed chars in case id
     local es=                           # exit status of this function
+    local lines=()                      # error message lines
     if grep "[^$allowed]" "$__xcase__tmp/enum";
     then
         if $__xcase__leaves || $__xcase__vars;
         then
-            jat__log_error "Sorry, when leaf directory mode (default) or variable"
-            jat__log_error "setting mode is used, range of characters that"
-            jat__log_error "xcase__enum() can emit is limited to:"
-            jat__log_error ""
-            jat__log_error "    $allowed"
-            jat__log_error ""
-            jat__log_error "This is to enable usage of this data as file, directory"
-            jat__log_error "and variable names.  To disable these modes, use flags"
-            jat__log_error "-L and -V, respectively."
-            jat__log_error "illegal characters in enumerator"
+            lines+=(
+                "Sorry, when leaf directory mode (default) or variable"
+                "setting mode is used, range of characters that"
+                "xcase__enum() can emit is limited to:"
+                ""
+                "    $allowed"
+                ""
+                "This is to enable usage of this data as file, directory"
+                "and variable names.  To disable these modes, use flags"
+                "-L and -V, respectively."
+                "illegal characters in enumerator"
+            )
             es=2
         else
-            jat__log_error "DEPRECATED characters in enumerator, future version will only allow: $allowed"
+            lines+=("DEPRECATED characters in enumerator, future version will only allow: $allowed")
             es=0
         fi
-        jat__log_error "Note that in order to make best use of xcase, the case id"
-        jat__log_error "should not hold any 'real' testing data but rather just"
-        jat__log_error "simple generic words to hint *intent* of the test case."
+        lines+=(
+            "Note that in order to make best use of xcase, the case id"
+             "should not hold any 'real' testing data but rather just"
+             "simple generic words to hint *intent* of the test case."
+         )
+         jat__log_error "${lines[@]}"
     fi
     return $es
 }