Refactor them to distinguish between source and destination accounts.
Also fix typo inherited from actual CSV field name.

gcconv.py

@@ -1,6 +1,10 @@
 # coding=utf-8
 """Convert Bank statement CSV to Gnucash-acceptable format"""
 
+from collections import namedtuple
+
+ParserState = namedtuple('ParserState', 'ths nxt')
+
 
 def valid_formats():
     return _parsers.keys()
@@ -53,14 +57,13 @@ class BaseTransactionParser(object):
 
     def __init__(self):
         self.transactions = []
-        self.state = False
-        self.next_state = False
+        self.state = ParserState(ths=False, nxt=False)
 
     def is_open(self):
-        return self.state
+        return self.state.ths
 
     def is_closed(self):
-        return not self.state
+        return not self.state.ths
 
     def parse_file(self, fpath, encoding='utf-8'):
         lines_read = 0
@@ -68,7 +71,7 @@ class BaseTransactionParser(object):
             for line in f.readlines():
                 line = line.decode(encoding).strip()
                 lines_read += 1
-                self.state = self.pick_state(line, lineno=lines_read)
+                self.state = self.advance(line, lineno=lines_read)
                 if self.is_open():
                     self.transactions.append(self.parse_line(line).to_gc())
 
@@ -82,32 +85,33 @@ class BaseTransactionParser(object):
 class MbankTransaction(BaseTransaction):
     """Item in an Mbank CSV"""
 
-    # Datum uskutečnění transakce
-    # Datum zaúčtování transakce
-    # Popis transakce
-    # Zpráva pro příjemce
-    # Plátce/Příjemce
-    # Číslo účtu plátce/příjemce
-    # KS
-    # VS
-    # SS
-    # Částka transakce
-    # Účetní zůstatek po transakci
+    # (a) Datum uskutečnění transakce
+    # (b) Datum zaúčtování transakce
+    # (c) Popis transakce
+    # (d) Zpráva pro příjemce
+    # (e) Plátce/Příjemce
+    # (f) Číslo účtu plátce/příjemce
+    # (g) KS
+    # (h) VS
+    # (i) SS
+    # (j) Částka transakce
+    # (k) Účetní zůstatek po transakci
+    # (l) (empty column at the end)
 
     def __init__(self, line):
         fields = [self._cleanup_field(f) for f in line.split(";")]
-        self.date_r = self._convert_date(fields.pop(0))
-        self.date_b = self._convert_date(fields.pop(0))
-        __ = fields.pop()
-        self.new_balance = self._parse_currency(fields.pop())
-        amount = self._parse_currency(fields.pop())
+        self.date_r = self._convert_date(fields.pop(0))         # (a)
+        self.date_b = self._convert_date(fields.pop(0))         # (b)
+        __ = fields.pop()                                       # (l)
+        self.new_balance = self._parse_currency(fields.pop())   # (k)
+        amount = self._parse_currency(fields.pop())             # (j)
         if amount >= 0:
             self.amountd = amount
             self.amountw = 0
         else:
             self.amountd = 0
             self.amountw = -amount
-        self._scrap = fields
+        self._scrap = fields                # (c-i)
 
     def _cleanup_field(self, field):
         x = ' '.join(_unquote(field).strip().split())
@@ -118,12 +122,36 @@ class MbankTransaction(BaseTransaction):
         return '-'.join([year, month, day])
 
     def _description(self):
+        def type_interesting(T):
+            boring_types = [
+                u'PŘÍCHOZÍ PLATBA Z MBANK',
+                u'ODCHOZÍ PLATBA DO MBANK',
+                u'PŘÍCHOZÍ PLATBA Z JINÉ BANKY',
+                u'ODCHOZÍ PLATBA DO JINÉ BANKY',
+                u'PLATBA KARTOU',
+            ]
+            if not T:
+                return False
+            if T in boring_types:
+                return False
+            return True
+        def message_interesting(M):
+            boring_messages = [
+                u'PŘEVOD PROSTŘEDKŮ',
+            ]
+            if not M:
+                return False
+            if M in boring_messages:
+                return False
+            return True
         type_, message, party, number, ks, vs, ss = self._scrap
-        message = message.replace(u' DATUM PROVEDENÍ TRANSAKCE: ', '; DATUM: ')
+        dpt = u' DATUM PROVEDENÍ TRANSAKCE: '
+        if dpt in message:
+            message, __ = message.split(dpt)
         out = []
-        if type_:
+        if type_interesting(type_):
             out.append(type_)
-        if message:
+        if message_interesting(message):
             out.append(message)
         if party:
             out.append(party)
@@ -150,16 +178,14 @@ class MbankTransactionParser(BaseTransactionParser):
     def parse_line(self, line):
         return MbankTransaction(line)
 
-    def pick_state(self, line, lineno=None):
+    def advance(self, line, lineno=None):
         """Choose parser state according to current line and line no."""
-        if self.next_state:
-            self.next_state = False
-            return True
+        if self.state.nxt:
+            return ParserState(ths=True, nxt=False)
         if self.is_closed() and line.startswith(u'#Datum uskute'):
-            self.next_state = True
-            return False
+            return ParserState(ths=False, nxt=True)
         if self.is_open() and not line:
-            return False
+            return ParserState(ths=False, nxt=False)
         return self.state
 
 
@@ -249,18 +275,121 @@ class FioTransactionParser(BaseTransactionParser):
     def parse_line(self, line):
         return FioTransaction(line)
 
-    def pick_state(self, line, lineno=None):
+    def advance(self, line, lineno=None):
         """Choose parser state according to current line and line no."""
-        if self.next_state:
-            self.next_state = False
-            return True
-        if self.is_closed() and line.startswith(u'"ID operace";"Datum";'):
-            self.next_state = True
-            return False
+        if self.state.nxt:
+            return ParserState(ths=True, nxt=False)
+        if self.is_open() and line.startswith(u'"ID operace";"Datum";'):
+            return ParserState(ths=False, nxt=True)
+        return self.state
+
+
+class RaifTransaction(BaseTransaction):
+
+    # (a) Transaction Date
+    # (b) Booking Date
+    # (c) Account number
+    # (d) Account Name
+    # (e) Transaction Category
+    # (f) Accocunt Number [SIC]
+    # (g) Name of Account
+    # (h) Transaction type
+    # (i) Message
+    # (j) Note
+    # (k) VS
+    # (l) KS
+    # (m) SS
+    # (n) Booked amount
+    # (o) Account Currency
+    # (p) Original Amount and Currency
+    # (q) Original Amount and Currency
+    # (r) Fee
+    # (s) Transaction ID
+
+    def __init__(self, line):
+        self._fields = [self._cleanup_field(f) for f in line.split(";")]
+        self.date = self._convert_date(self._fields[0])
+        amount = self._parse_currency(self._fields[13])
+        if amount >= 0:
+            self.amountd = amount
+            self.amountw = 0
+        else:
+            self.amountd = 0
+            self.amountw = -amount
+        self.currency = self._fields[14]
+        assert self.currency == 'CZK'
+
+    def _cleanup_field(self, field):
+        x = ' '.join(_unquote(field).strip().split())
+        return '' if x == '-' else x
+
+    def _description(self):
+        (
+            transaction_date,
+            booking_date,
+            src_account_number,
+            src_account_name,
+            transaction_category,
+            dst_account_number,
+            dst_account_name,
+            dst_ransaction_type,
+            message,
+            note,
+            vs,
+            ks,
+            ss,
+            booked_amount,
+            account_currency,
+            original_amount_and_currency,
+            original_amount_and_currency,
+            fee,
+            transaction_id,
+            ) = self._fields
+        out = []
+        if message:
+            out.append(message)
+        if note and note != message:
+            out.append(note)
+        if dst_account_name:
+            out.append(dst_account_name)
+        else:
+            out.append(dst_account_number)
+        out.append("VS:%s" % vs)
+        return " / ".join(out)
+
+    def _convert_date(self, text):
+        day, month, year = text.split('.')
+        return '-'.join([year, month, day])
+
+    def _parse_currency(self, text):
+        return float(text.replace(',', '.').replace(' ', ''))
+
+    def to_gc(self):
+        """Convert to GCTransaction"""
+        return GCTransaction(
+            date=self.date,
+            deposit=self.amountd,
+            withdrawal=self.amountw,
+            description=self._description()
+        )
+
+
+class RaifTransactionParser(BaseTransactionParser):
+
+    def parse_line(self, line):
+        return RaifTransaction(line)
+
+    def advance(self, line, lineno=None):
+        """Choose parser state according to current line and line no."""
+        if self.state.nxt:
+            return ParserState(ths=True, nxt=False)
+        if self.is_closed() and line.startswith(u'Transaction Date;Booking'):
+            return ParserState(ths=False, nxt=True)
         return self.state
 
 
 _parsers = {
     'CzMbank': MbankTransactionParser,
     'CzFio': FioTransactionParser,
+    'CzRaif': RaifTransactionParser,
 }