Merge 4a9b5f7357cc720acb86af7d5f03ba0d5bbd6111 into c5fb45423ec1ee1080e442e061ccfcdb98b32e4a

src/helpers.c

@@ -143,7 +143,6 @@ int light_mkpath(char *dir, mode_t mode)
     char *tempdir = strdup(dir);
     light_mkpath(dirname(tempdir), mode);
     free(tempdir);
-    
+
     return mkdir(dir, mode);
 }
-

src/helpers.h

@@ -53,4 +53,3 @@ uint64_t light_log_clamp_max(uint64_t max);
 double light_percent_clamp(double percent);
 
 int light_mkpath(char *dir, mode_t mode);
-

src/impl/razer.c

@@ -12,7 +12,7 @@ static void _impl_razer_add_target(light_device_t *device, char const *name, cha
     impl_razer_data_t *target_data = malloc(sizeof(impl_razer_data_t));
     snprintf(target_data->brightness, sizeof(target_data->brightness), "/sys/bus/hid/drivers/razerkbd/%s/%s", device->name, filename);
     target_data->max_brightness = max_brightness;
-    
+
     // Only add targets that actually exist, as we aren't fully sure exactly what targets exist for a given device
     if(light_file_exists(target_data->brightness))
     {
@@ -33,7 +33,7 @@ static void _impl_razer_add_device(light_device_enumerator_t *enumerator, char c
 
     // Setup a target to backlight
     _impl_razer_add_target(new_device, "backlight", "matrix_brightness", 255);
-    
+
     // Setup targets to different possible leds
     _impl_razer_add_target(new_device, "game_led", "game_led_state", 1);
     _impl_razer_add_target(new_device, "macro_led", "macro_led_state", 1);
@@ -48,13 +48,13 @@ bool impl_razer_init(light_device_enumerator_t *enumerator)
     // Iterate through the led controllers and create a device_target for each controller 
     DIR *razer_dir;
     struct dirent *curr_entry;
-    
+
     if((razer_dir = opendir("/sys/bus/hid/drivers/razerkbd/")) == NULL)
     {
         // Razer driver isnt properly installed, so we cant add devices in this enumerator 
         return true;
     }
-    
+
     while((curr_entry = readdir(razer_dir)) != NULL)
     {
         // Skip dot entries
@@ -62,12 +62,12 @@ bool impl_razer_init(light_device_enumerator_t *enumerator)
         {
             continue;
         }
- 
+
         _impl_razer_add_device(enumerator, curr_entry->d_name);
     }
-    
+
     closedir(razer_dir);
-    
+
     return true;
 }
 
@@ -85,7 +85,7 @@ bool impl_razer_set(light_device_target_t *target, uint64_t in_value)
         LIGHT_ERR("failed to write to razer device");
         return false;
     }
-    
+
     return true;
 }
 
@@ -98,7 +98,7 @@ bool impl_razer_get(light_device_target_t *target, uint64_t *out_value)
         LIGHT_ERR("failed to read from razer device");
         return false;
     }
-    
+
     return true;
 }
 
@@ -107,7 +107,7 @@ bool impl_razer_getmax(light_device_target_t *target, uint64_t *out_value)
     impl_razer_data_t *data = (impl_razer_data_t*)target->device_target_data;
 
     *out_value = data->max_brightness;
-    
+
     return true;
 }
 
@@ -117,5 +117,3 @@ bool impl_razer_command(light_device_target_t *target, char const *command_strin
     // To implement support, simply parse the command string to your liking, and return false on invalid input or results!
     return true;
 }
-
-

src/impl/sysfs.c

@@ -15,13 +15,13 @@ static bool _impl_sysfs_init_leds(light_device_enumerator_t *enumerator)
     // Iterate through the led controllers and create a device_target for each controller 
     DIR *leds_dir;
     struct dirent *curr_entry;
-    
+
     if((leds_dir = opendir("/sys/class/leds")) == NULL)
     {
         LIGHT_ERR("failed to open leds controller directory for reading");
         return false;
     }
-    
+
     while((curr_entry = readdir(leds_dir)) != NULL)
     {
         // Skip dot entries
@@ -29,18 +29,18 @@ static bool _impl_sysfs_init_leds(light_device_enumerator_t *enumerator)
         {
             continue;
         }
-        
+
         // Setup the target data 
         impl_sysfs_data_t *dev_data = malloc(sizeof(impl_sysfs_data_t));
         snprintf(dev_data->brightness, sizeof(dev_data->brightness), "/sys/class/leds/%s/brightness", curr_entry->d_name);
         snprintf(dev_data->max_brightness, sizeof(dev_data->max_brightness), "/sys/class/leds/%s/max_brightness", curr_entry->d_name);
-        
+
         // Create a new device target for the controller 
         light_create_device_target(leds_device, curr_entry->d_name, impl_sysfs_set, impl_sysfs_get, impl_sysfs_getmax, impl_sysfs_command, dev_data);
     }
-    
+
     closedir(leds_dir);
-    
+
     return true;
 }
 
@@ -52,17 +52,17 @@ static bool _impl_sysfs_init_backlight(light_device_enumerator_t *enumerator)
     // Iterate through the backlight controllers and create a device_target for each controller 
     DIR *backlight_dir;
     struct dirent *curr_entry;
-    
+
     // Keep track of the best controller, and create an autodevice from that
     char best_controller[NAME_MAX];
     uint64_t best_value = 0;
-    
+
     if((backlight_dir = opendir("/sys/class/backlight")) == NULL)
     {
         LIGHT_ERR("failed to open backlight controller directory for reading");
         return false;
     }
-    
+
     while((curr_entry = readdir(backlight_dir)) != NULL)
     {
         // Skip dot entries
@@ -70,15 +70,15 @@ static bool _impl_sysfs_init_backlight(light_device_enumerator_t *enumerator)
         {
             continue;
         }
-        
+
         // Setup the target data 
         impl_sysfs_data_t *dev_data = malloc(sizeof(impl_sysfs_data_t));
         snprintf(dev_data->brightness, sizeof(dev_data->brightness), "/sys/class/backlight/%s/brightness", curr_entry->d_name);
         snprintf(dev_data->max_brightness, sizeof(dev_data->max_brightness), "/sys/class/backlight/%s/max_brightness", curr_entry->d_name);
-        
+
         // Create a new device target for the controller 
         light_create_device_target(backlight_device, curr_entry->d_name, impl_sysfs_set, impl_sysfs_get, impl_sysfs_getmax, impl_sysfs_command, dev_data);
-        
+
         // Read the max brightness to get the best one
         uint64_t curr_value = 0;
         if(light_file_read_uint64(dev_data->max_brightness, &curr_value))
@@ -90,9 +90,9 @@ static bool _impl_sysfs_init_backlight(light_device_enumerator_t *enumerator)
             }
         }
     }
-    
+
     closedir(backlight_dir);
-    
+
     // If we found at least one usable controller, create an auto target mapped to that controller
     if(best_value > 0)
     {
@@ -100,11 +100,11 @@ static bool _impl_sysfs_init_backlight(light_device_enumerator_t *enumerator)
         impl_sysfs_data_t *dev_data = malloc(sizeof(impl_sysfs_data_t));
         snprintf(dev_data->brightness, sizeof(dev_data->brightness), "/sys/class/backlight/%s/brightness", best_controller);
         snprintf(dev_data->max_brightness, sizeof(dev_data->max_brightness), "/sys/class/backlight/%s/max_brightness", best_controller);
-        
+
         // Create a new device target for the controller 
         light_create_device_target(backlight_device, "auto", impl_sysfs_set, impl_sysfs_get, impl_sysfs_getmax, impl_sysfs_command, dev_data);
     }
-    
+
     return true;
 }
 
@@ -112,10 +112,10 @@ bool impl_sysfs_init(light_device_enumerator_t *enumerator)
 {
     // Create a device for the backlight 
     _impl_sysfs_init_backlight(enumerator);
-    
+
     // Create devices for the leds
     _impl_sysfs_init_leds(enumerator);
-    
+
     return true;
 }
 
@@ -133,7 +133,7 @@ bool impl_sysfs_set(light_device_target_t *target, uint64_t in_value)
         LIGHT_ERR("failed to write to sysfs device");
         return false;
     }
-    
+
     return true;
 }
 
@@ -146,7 +146,7 @@ bool impl_sysfs_get(light_device_target_t *target, uint64_t *out_value)
         LIGHT_ERR("failed to read from sysfs device");
         return false;
     }
-    
+
     return true;
 }
 
@@ -159,7 +159,7 @@ bool impl_sysfs_getmax(light_device_target_t *target, uint64_t *out_value)
         LIGHT_ERR("failed to read from sysfs device");
         return false;
     }
-    
+
     return true;
 }
 
@@ -169,5 +169,3 @@ bool impl_sysfs_command(light_device_target_t *target, char const *command_strin
     // To implement support, simply parse the command string to your liking, and return false on invalid input or results!
     return true;
 }
-
-

src/impl/util.c

@@ -45,5 +45,3 @@ bool impl_util_dryrun_command(light_device_target_t *target, char const *command
     LIGHT_NOTE("impl_util_dryrun_command: running custom command on utility target %s: \"%s\"", target->name, command_string);
     return true;
 }
-
-

src/light.c

@@ -17,28 +17,27 @@
 
 /* Static helper functions for this file only, prefix with _ */
 
-
 static void _light_add_enumerator_device(light_device_enumerator_t *enumerator, light_device_t *new_device)
 {
     // Create a new device array 
     uint64_t new_num_devices = enumerator->num_devices + 1;
     light_device_t **new_devices = malloc(new_num_devices * sizeof(light_device_t*));
-    
+
     // Copy old device array to new one
     for(uint64_t i = 0; i < enumerator->num_devices; i++)
     {
         new_devices[i] = enumerator->devices[i];
     }
-    
+
     // Set the new device
     new_devices[enumerator->num_devices] = new_device;
-    
+
     // Free the old devices array, if needed
     if(enumerator->devices != NULL)
     {
         free(enumerator->devices);
     }
-    
+
     // Replace the devices array with the new one
     enumerator->devices = new_devices;
     enumerator->num_devices = new_num_devices;
@@ -49,22 +48,22 @@ static void _light_add_device_target(light_device_t *device, light_device_target
     // Create a new targets array 
     uint64_t new_num_targets = device->num_targets + 1;
     light_device_target_t **new_targets = malloc(new_num_targets * sizeof(light_device_target_t*));
-    
+
     // Copy old targets array to new one
     for(uint64_t i = 0; i < device->num_targets; i++)
     {
         new_targets[i] = device->targets[i];
     }
-    
+
     // Set the new target
     new_targets[device->num_targets] = new_target;
-    
+
     // Free the old targets array, if needed
     if(device->targets != NULL)
     {
         free(device->targets);
     }
-    
+
     // Replace the targets array with the new one
     device->targets= new_targets;
     device->num_targets = new_num_targets;
@@ -103,7 +102,7 @@ static uint64_t _light_get_min_cap(light_context_t *ctx)
     {
         return 0;
     }
-    
+
     return minimum_value;
 }
 
@@ -116,7 +115,7 @@ static light_device_enumerator_t* _light_find_enumerator(light_context_t *ctx, c
             return ctx->enumerators[e];
         }
     }
-    
+
     return NULL;
 }
 
@@ -129,7 +128,7 @@ static light_device_t* _light_find_device(light_device_enumerator_t *en, char co
             return en->devices[d];
         }
     }
-    
+
     return NULL;
 }
 
@@ -142,24 +141,24 @@ static light_device_target_t* _light_find_target(light_device_t * dev, char cons
             return dev->targets[t];
         }
     }
-    
+
     return NULL;
 }
 
 static bool _light_raw_to_percent(light_device_target_t *target, uint64_t inraw, double *outpercent)
 {
-        double inraw_d = (double)inraw;
-        uint64_t max_value = 0;
-        if(!target->get_max_value(target, &max_value))
-        {
-            LIGHT_ERR("couldn't read from target");
-            return false;
-        }
-        double max_value_d = (double)max_value;
-        double percent = light_percent_clamp((inraw_d / max_value_d) * 100.0);
-        *outpercent = percent;
-        
-        return true;
+    double inraw_d = (double)inraw;
+    uint64_t max_value = 0;
+    if(!target->get_max_value(target, &max_value))
+    {
+        LIGHT_ERR("couldn't read from target");
+        return false;
+    }
+    double max_value_d = (double)max_value;
+    double percent = light_percent_clamp((inraw_d / max_value_d) * 100.0);
+    *outpercent = percent;
+
+    return true;
 }
 
 static bool _light_percent_to_raw(light_device_target_t *target, double inpercent, uint64_t *outraw)
@@ -175,7 +174,7 @@ static bool _light_percent_to_raw(light_device_target_t *target, double inpercen
     double target_value_d = max_value_d * (light_percent_clamp(inpercent) / 100.0);
     uint64_t target_value = LIGHT_CLAMP((uint64_t)target_value_d, 0, max_value);
     *outraw = target_value;
-    
+
     return true;
 }
 
@@ -224,7 +223,7 @@ static bool _light_set_context_command(light_context_t *ctx, LFUNCCOMMAND new_cm
         LIGHT_WARN("a command was already set. ignoring.");
         return false;
     }
-    
+
     ctx->run_params.command = new_cmd;
     return true;
 }
@@ -233,20 +232,20 @@ static bool _light_parse_arguments(light_context_t *ctx, int argc, char** argv)
 {
     int32_t curr_arg = -1;
     int32_t log_level = 0;
-    
+
     char ctrl_name[NAME_MAX];
     bool need_value = false;
     bool need_float_value = false;
     bool need_target = true; // default cmd is get brightness
     bool specified_target = false;
     snprintf(ctrl_name, sizeof(ctrl_name), "%s", "sysfs/backlight/auto");
-    
+
     while((curr_arg = getopt(argc, argv, "HhVGSLMNPAUTOIv:s:r")) != -1)
     {
         switch(curr_arg)
         {
             // Options
-            
+
             case 'v':
                 if(sscanf(optarg, "%i", &log_level) != 1)
                 {
@@ -254,14 +253,14 @@ static bool _light_parse_arguments(light_context_t *ctx, int argc, char** argv)
                     _light_print_usage();
                     return false;
                 }
-                
+
                 if(log_level < 0 || log_level > 3)
                 {
                     fprintf(stderr, "-v argument must be between 0 and 3.\n\n");
                     _light_print_usage();
                     return false;
                 }
-                
+
                 light_loglevel = (light_loglevel_t)log_level;
                 break;
             case 's':
@@ -271,7 +270,7 @@ static bool _light_parse_arguments(light_context_t *ctx, int argc, char** argv)
             case 'r':
                 ctx->run_params.raw_mode = true;
                 break;
-            
+
             // Commands
             case 'H':
             case 'h':
@@ -335,7 +334,7 @@ static bool _light_parse_arguments(light_context_t *ctx, int argc, char** argv)
     {
         _light_set_context_command(ctx, light_cmd_get_brightness);
     }
-    
+
     if(need_target)
     {
         light_device_target_t *curr_target = light_find_device_target(ctx, ctrl_name);
@@ -352,7 +351,7 @@ static bool _light_parse_arguments(light_context_t *ctx, int argc, char** argv)
                 curr_target = light_find_device_target(ctx, "util/test/dryrun");
             }
         }
-        
+
         ctx->run_params.device_target = curr_target;
     }
 
@@ -386,7 +385,7 @@ static bool _light_parse_arguments(light_context_t *ctx, int argc, char** argv)
                 _light_print_usage();
                 return false;
             }
-            
+
             percent_value = light_percent_clamp(percent_value);
             
             uint64_t raw_value = 0;
@@ -395,7 +394,7 @@ static bool _light_parse_arguments(light_context_t *ctx, int argc, char** argv)
                 LIGHT_ERR("failed to convert from percent to raw for device target");
                 return false;
             }
-            
+
             ctx->run_params.value = raw_value;
         }
     }
@@ -411,12 +410,9 @@ static bool _light_parse_arguments(light_context_t *ctx, int argc, char** argv)
     }
 
     return true;
-    
 }
 
 
-
-
 /* API function definitions */
 
 light_context_t* light_initialize(int argc, char **argv)
@@ -456,7 +452,6 @@ light_context_t* light_initialize(int argc, char **argv)
     else
     {
         char *xdg_conf = getenv("XDG_CONFIG_HOME");
-        
         if(xdg_conf != NULL)
         {
             snprintf(new_ctx->sys_params.conf_dir, sizeof(new_ctx->sys_params.conf_dir), "%s/light", xdg_conf);
@@ -466,7 +461,7 @@ light_context_t* light_initialize(int argc, char **argv)
             snprintf(new_ctx->sys_params.conf_dir, sizeof(new_ctx->sys_params.conf_dir), "%s/.config/light", getenv("HOME"));
         }
     }
-    
+
     // Make sure the configuration folder exists, otherwise attempt to create it
     int32_t rc = light_mkpath(new_ctx->sys_params.conf_dir, S_IRWXU | S_IRWXG | S_IROTH | S_IXOTH);
     if(rc && errno != EEXIST)
@@ -474,7 +469,7 @@ light_context_t* light_initialize(int argc, char **argv)
         LIGHT_WARN("couldn't create configuration directory");
         return false;
     }
-    
+
     // Create the built-in enumerators
     light_create_enumerator(new_ctx, "sysfs", &impl_sysfs_init, &impl_sysfs_free);
     light_create_enumerator(new_ctx, "util", &impl_util_init, &impl_util_free);
@@ -496,7 +491,7 @@ light_context_t* light_initialize(int argc, char **argv)
         LIGHT_ERR("failed to parse arguments");
         return NULL;
     }
-    
+
     return new_ctx;
 }
 
@@ -507,7 +502,7 @@ bool light_execute(light_context_t *ctx)
         LIGHT_ERR("run parameters command was null, can't execute");
         return false;
     }
-    
+
     return ctx->run_params.command(ctx);
 }
 
@@ -517,7 +512,7 @@ void light_free(light_context_t *ctx)
     {
         LIGHT_WARN("failed to free all enumerators");
     }
-    
+
     free(ctx);
 }
 
@@ -526,29 +521,29 @@ light_device_enumerator_t * light_create_enumerator(light_context_t *ctx, char c
     // Create a new enumerator array 
     uint64_t new_num_enumerators = ctx->num_enumerators + 1;
     light_device_enumerator_t **new_enumerators = malloc(new_num_enumerators * sizeof(light_device_enumerator_t*));
-    
+
     // Copy old enumerator array to new one
     for(uint64_t i = 0; i < ctx->num_enumerators; i++)
     {
         new_enumerators[i] = ctx->enumerators[i];
     }
-    
+
     // Allocate the new enumerator
     new_enumerators[ctx->num_enumerators] = malloc(sizeof(light_device_enumerator_t));
     light_device_enumerator_t *returner = new_enumerators[ctx->num_enumerators];
-    
+
     returner->devices = NULL;
     returner->num_devices = 0;
     returner->init = init_func;
     returner->free = free_func;
     snprintf(returner->name, sizeof(returner->name), "%s", name);
-    
+
     // Free the old enumerator array, if needed
     if(ctx->enumerators != NULL)
     {
         free(ctx->enumerators);
     }
-    
+
     // Replace the enumerator array with the new one
     ctx->enumerators = new_enumerators;
     ctx->num_enumerators = new_num_enumerators;
@@ -568,7 +563,7 @@ bool light_init_enumerators(light_context_t *ctx)
             success = false;
         }
     }
-    
+
     return success;
 }
 
@@ -578,30 +573,29 @@ bool light_free_enumerators(light_context_t *ctx)
     for(uint64_t i = 0; i < ctx->num_enumerators; i++)
     {
         light_device_enumerator_t * curr_enumerator = ctx->enumerators[i];
-        
         if(!curr_enumerator->free(curr_enumerator))
         {
             success = false;
         }
-        
+
         if(curr_enumerator->devices != NULL)
         {
             for(uint64_t d = 0; d < curr_enumerator->num_devices; d++)
             {
                 light_delete_device(curr_enumerator->devices[d]);
             }
-            
+
             free(curr_enumerator->devices);
             curr_enumerator->devices = NULL;
         }
-        
+
         free(curr_enumerator);
     }
-    
+
     free(ctx->enumerators);
     ctx->enumerators = NULL;
     ctx->num_enumerators = 0;
-    
+
     return success;
 }
 
@@ -614,11 +608,11 @@ bool light_split_target_path(char const *in_path, light_target_path_t *out_path)
         LIGHT_WARN("invalid path passed to split_target_path");
         return false;
     }
-    
+
     size_t size = end - begin;
     strncpy(out_path->enumerator, begin, size);
     out_path->enumerator[size] = '\0';
-    
+
     begin = end + 1;
     end = strstr(begin, "/");
     if(end == NULL)
@@ -626,13 +620,13 @@ bool light_split_target_path(char const *in_path, light_target_path_t *out_path)
         LIGHT_WARN("invalid path passed to split_target_path");
         return false;
     }
-    
+
     size = end - begin;
     strncpy(out_path->device, begin, size);
     out_path->device[size] = '\0';
-    
+
     strcpy(out_path->target, end + 1);
-    
+
     return true;
 }
 
@@ -644,7 +638,7 @@ light_device_target_t* light_find_device_target(light_context_t *ctx, char const
         LIGHT_WARN("light_find_device_target needs a path in the format of \"enumerator/device/target\", the following format is not recognized:  \"%s\"", name);
         return NULL;
     }
-    
+
     /*
     Uncomment to debug the split function
     printf("enumerator: %s %u\ndevice: %s %u\ntarget: %s %u\n",
@@ -652,30 +646,30 @@ light_device_target_t* light_find_device_target(light_context_t *ctx, char const
             new_path.device, strlen(new_path.device),
             new_path.target, strlen(new_path.target));
     */
-    
+
     // find a matching enumerator 
-    
+
     light_device_enumerator_t *enumerator = _light_find_enumerator(ctx, new_path.enumerator);
     if(enumerator == NULL)
     {
         LIGHT_WARN("no such enumerator, \"%s\"", new_path.enumerator);
         return NULL;
     }
-    
+
     light_device_t *device = _light_find_device(enumerator, new_path.device);
     if(device == NULL)
     {
         LIGHT_WARN("no such device, \"%s\"", new_path.device);
         return NULL;
     }
-    
+
     light_device_target_t *target = _light_find_target(device, new_path.target);
     if(target == NULL)
     {
         LIGHT_WARN("no such target, \"%s\"", new_path.target);
         return NULL;
     }
-    
+
     return target;
 }
 
@@ -703,12 +697,11 @@ bool light_cmd_list_devices(light_context_t *ctx)
             for(uint64_t target = 0; target < curr_device->num_targets; target++)
             {
                 light_device_target_t *curr_target = curr_device->targets[target];
-                
                 printf("\t%s/%s/%s\n", curr_enumerator->name, curr_device->name, curr_target->name);
             }
         }
     }
-    
+
     return true;
 }
 
@@ -720,21 +713,20 @@ bool light_cmd_set_brightness(light_context_t *ctx)
         LIGHT_ERR("didn't have a valid target, programmer mistake");
         return false;
     }
-    
-    
+
     uint64_t mincap = _light_get_min_cap(ctx);
     uint64_t value = ctx->run_params.value;
     if(mincap > value)
     {
         value = mincap;
     }
-    
+
     if(!target->set_value(target, value))
     {
         LIGHT_ERR("failed to write to target");
         return false;
     }
-    
+
     return true;
 }
 
@@ -746,14 +738,14 @@ bool light_cmd_get_brightness(light_context_t *ctx)
         LIGHT_ERR("didn't have a valid target, programmer mistake");
         return false;
     }
-    
+
     uint64_t value = 0;
     if(!target->get_value(target, &value))
     {
         LIGHT_ERR("failed to read from target");
         return false;
     }
-    
+
     if(ctx->run_params.raw_mode)
     {
         printf("%" PRIu64 "\n", value);
@@ -768,7 +760,7 @@ bool light_cmd_get_brightness(light_context_t *ctx)
         }
         printf("%.2f\n", percent);
     }
-    
+
     return true;
 }
 
@@ -780,20 +772,20 @@ bool light_cmd_get_max_brightness(light_context_t *ctx)
         LIGHT_ERR("didn't have a valid target, programmer mistake");
         return false;
     }
-    
+
     if(!ctx->run_params.raw_mode)
     {
         printf("100.0\n");
         return true;
     }
-    
+
     uint64_t max_value = 0;
     if(!target->get_max_value(target, &max_value))
     {
         LIGHT_ERR("failed to read from device target");
         return false;
     }
-    
+
     printf("%" PRIu64 "\n", max_value);
     return true;
 }
@@ -802,7 +794,7 @@ bool light_cmd_set_min_brightness(light_context_t *ctx)
 {
     char target_path[NAME_MAX];
     _light_get_target_path(ctx, target_path, sizeof(target_path));
-    
+
     // Make sure the target folder exists, otherwise attempt to create it
     int32_t rc = light_mkpath(target_path, S_IRWXU | S_IRWXG | S_IROTH | S_IXOTH);
     if(rc && errno != EEXIST)
@@ -810,16 +802,16 @@ bool light_cmd_set_min_brightness(light_context_t *ctx)
         LIGHT_ERR("couldn't create target directory for minimum brightness");
         return false;
     }
-    
+
     char target_filepath[NAME_MAX];
     _light_get_target_file(ctx, target_filepath, sizeof(target_filepath), "minimum");
-    
+
     if(!light_file_write_uint64(target_filepath, ctx->run_params.value))
     {
         LIGHT_ERR("couldn't write value to minimum file");
         return false;
     }
-    
+
     return true;
 }
 
@@ -842,7 +834,7 @@ bool light_cmd_get_min_brightness(light_context_t *ctx)
 
         return true;
     }
-    
+
     if(ctx->run_params.raw_mode)
     {
         printf("%" PRIu64 "\n", minimum_value);
@@ -855,10 +847,10 @@ bool light_cmd_get_min_brightness(light_context_t *ctx)
             LIGHT_ERR("failed to convert value from raw to percent for device target");
             return false;
         }
-        
+
         printf("%.2f\n", minimum_d);
     }
-    
+
     return true;
 }
 
@@ -870,41 +862,39 @@ bool light_cmd_add_brightness(light_context_t *ctx)
         LIGHT_ERR("didn't have a valid target, programmer mistake");
         return false;
     }
-    
+
     uint64_t value = 0;
     if(!target->get_value(target, &value))
     {
         LIGHT_ERR("failed to read from target");
         return false;
     }
-    
+
     uint64_t max_value = 0;
     if(!target->get_max_value(target, &max_value))
     {
         LIGHT_ERR("failed to read from target");
         return false;
     }
-    
+
     value += ctx->run_params.value;
-    
     uint64_t mincap = _light_get_min_cap(ctx);
     if(mincap > value)
     {
         value = mincap;
     }
-    
-    
+
     if(value > max_value)
     {
         value = max_value;
     }
-    
+
     if(!target->set_value(target, value))
     {
         LIGHT_ERR("failed to write to target");
         return false;
     }
-    
+
     return true;
 }
 
@@ -916,14 +906,14 @@ bool light_cmd_sub_brightness(light_context_t *ctx)
         LIGHT_ERR("didn't have a valid target, programmer mistake");
         return false;
     }
-    
+
     uint64_t value = 0;
     if(!target->get_value(target, &value))
     {
         LIGHT_ERR("failed to read from target");
         return false;
     }
-    
+
     if(value > ctx->run_params.value)
     {
         value -= ctx->run_params.value;
@@ -932,7 +922,7 @@ bool light_cmd_sub_brightness(light_context_t *ctx)
     {
         value = 0;
     }
-    
+
     uint64_t mincap = _light_get_min_cap(ctx);
     if(mincap > value)
     {
@@ -944,7 +934,7 @@ bool light_cmd_sub_brightness(light_context_t *ctx)
         LIGHT_ERR("failed to write to target");
         return false;
     }
-    
+
     return true;
 }
 
@@ -973,7 +963,7 @@ bool light_cmd_mul_brightness(light_context_t *ctx)
 
     uint64_t old_value = value;
     value *= ctx->run_params.float_value;
- 
+
     // Check that we actually de/increase value
     if(value == old_value)
     {
@@ -1007,7 +997,7 @@ bool light_cmd_save_brightness(light_context_t *ctx)
 {
     char target_path[NAME_MAX];
     _light_get_target_path(ctx, target_path, sizeof(target_path));
-    
+
     // Make sure the target folder exists, otherwise attempt to create it
     int32_t rc = light_mkpath(target_path, S_IRWXU | S_IRWXG | S_IROTH | S_IXOTH);
     if(rc && errno != EEXIST)
@@ -1015,7 +1005,7 @@ bool light_cmd_save_brightness(light_context_t *ctx)
         LIGHT_ERR("couldn't create target directory for save brightness");
         return false;
     }
-    
+
     char target_filepath[NAME_MAX];
     _light_get_target_file(ctx, target_filepath, sizeof(target_filepath), "save");
 
@@ -1025,13 +1015,13 @@ bool light_cmd_save_brightness(light_context_t *ctx)
         LIGHT_ERR("couldn't read from device target");
         return false;
     }
-    
+
     if(!light_file_write_uint64(target_filepath, curr_value))
     {
         LIGHT_ERR("couldn't write value to savefile");
         return false;
     }
-    
+
     return true;
 }
 
@@ -1046,19 +1036,19 @@ bool light_cmd_restore_brightness(light_context_t *ctx)
         LIGHT_ERR("couldn't read value from savefile");
         return false;
     }
-    
+
     uint64_t mincap = _light_get_min_cap(ctx);
     if(mincap > saved_value)
     {
         saved_value = mincap;
     }
-    
+
     if(!ctx->run_params.device_target->set_value(ctx->run_params.device_target, saved_value))
     {
         LIGHT_ERR("couldn't write saved value to device target");
         return false;
     }
-    
+
     return true;
 }
 
@@ -1069,11 +1059,11 @@ light_device_t *light_create_device(light_device_enumerator_t *enumerator, char
     new_device->targets = NULL;
     new_device->num_targets = 0;
     new_device->device_data = device_data;
-    
+
     snprintf(new_device->name, sizeof(new_device->name), "%s", name);
-    
+
     _light_add_enumerator_device(enumerator, new_device);
-    
+
     return new_device;
 }
 
@@ -1083,21 +1073,27 @@ void light_delete_device(light_device_t *device)
     {
         light_delete_device_target(device->targets[i]);
     }
-    
+
     if(device->targets != NULL)
     {
         free(device->targets);
     }
-    
+
     if(device->device_data != NULL)
     {
         free(device->device_data);
     }
-    
+
     free(device);
 }
 
-light_device_target_t *light_create_device_target(light_device_t *device, char const *name, LFUNCVALSET setfunc, LFUNCVALGET getfunc, LFUNCMAXVALGET getmaxfunc, LFUNCCUSTOMCMD cmdfunc, void *target_data)
+light_device_target_t *light_create_device_target(light_device_t *device,
+                                                    char const *name,
+                                                    LFUNCVALSET setfunc,
+                                                    LFUNCVALGET getfunc,
+                                                    LFUNCMAXVALGET getmaxfunc,
+                                                    LFUNCCUSTOMCMD cmdfunc,
+                                                    void *target_data)
 {
     light_device_target_t *new_target = malloc(sizeof(light_device_target_t));
     new_target->device = device;
@@ -1106,11 +1102,11 @@ light_device_target_t *light_create_device_target(light_device_t *device, char c
     new_target->get_max_value = getmaxfunc;
     new_target->custom_command = cmdfunc;
     new_target->device_target_data = target_data;
-    
+
     snprintf(new_target->name, sizeof(new_target->name), "%s", name);
-    
+
     _light_add_device_target(device, new_target);
-    
+
     return new_target;
 }
 
@@ -1120,6 +1116,6 @@ void light_delete_device_target(light_device_target_t *device_target)
     {
         free(device_target->device_target_data);
     }
-    
+
     free(device_target);
 }

src/light.h

@@ -8,7 +8,7 @@
 
 #include "config.h"
 
-#define LIGHT_YEAR   "2012 - 2018"
+#define LIGHT_YEAR   "2012 - 2022"
 #define LIGHT_AUTHOR "Fredrik Haikarainen"
 
 struct _light_device_target_t;
@@ -41,14 +41,13 @@ struct _light_device_target_t
 /* Describes a device (a backlight, a keyboard, a led-strip) */
 struct _light_device_t
 {
-    char                  name[256];
-    light_device_target_t **targets;
-    uint64_t              num_targets;
-    void                  *device_data;
+    char                      name[256];
+    light_device_target_t     **targets;
+    uint64_t                  num_targets;
+    void                      *device_data;
     light_device_enumerator_t *enumerator;
 };
 
-
 typedef bool (*LFUNCENUMINIT)(light_device_enumerator_t*);
 typedef bool (*LFUNCENUMFREE)(light_device_enumerator_t*);
 
@@ -84,7 +83,7 @@ struct _light_context_t
     {
         char                    conf_dir[NAME_MAX]; // The path to the application cache directory 
     } sys_params;
-    
+
     light_device_enumerator_t   **enumerators;
     uint64_t                    num_enumerators;
 };
@@ -146,4 +145,3 @@ bool light_split_target_path(char const * in_path, light_target_path_t *out_path
 
 /* Returns the found device target, or null. Name should be enumerator/device/target */
 light_device_target_t* light_find_device_target(light_context_t *ctx, char const * name);
-