Abdullah ibn Nadjo
f62503b299
Fix different kinds of issues with string buffers and pointers
- Use NAME_MAX and PATH_MAX instead of hardcoded values
- Allow paths to be longer than 256 chars
- Check pointers everywhere
- Use strncpy/snprintf instead of strcpy/sprintf
- Validate controllers' name (-s flag + a very long name -> bad things happening)
- Get rid of globals for dir iteration
7 år sedan
Abdullah ibn Nadjo
fa2fba14a6
Fix overflow of raw values < 0
- Rewrite of all clamp operations
- Get rid of unreachable code (the 'else' in the last chunk)
7 år sedan
Abdullah ibn Nadjo
c363ac40a1
Check if specified operation is valid for the wanted field
7 år sedan
Abdullah ibn Nadjo
9032c14237
Print errors to stderr
7 år sedan
Abdullah ibn Nadjo
0ecb5353aa
Don't forget to init variables
7 år sedan
Abdullah ibn Nadjo
bcaa7df99b
Don't try to read brightness values when only targetting max bright.
7 år sedan
Abdullah ibn Nadjo
5d3c89630c
Update README to explain changes introduced in cd70ff5
Also add more examples
7 år sedan
Abdullah ibn Nadjo
cd70ff5e01
Create a flag category only for backlight/kbd
Now we can save, restore, get [max] brightness etc. for both screen
and keyboard controllers
7 år sedan
Abdullah ibn Nadjo
6180bb3f5c
Logging of clamps, saves and restores
7 år sedan
Abdullah ibn Nadjo
f288657500
Rewrite light_execute for readability and avoiding unnecessary oper.
7 år sedan
Abdullah ibn Nadjo
6860e111a5
Cache max brightness data from automatic controller detection
7 år sedan
Abdullah ibn Nadjo
9fda8acac0
Improve light folder checking readability
7 år sedan
Abdullah ibn Nadjo
ccff2b57cd
Improve overall logging
7 år sedan
Abdullah ibn Nadjo
55fe7a9eaf
Don't check unsigned int about negative values
7 år sedan
Abdullah ibn Nadjo
9f9d6ae447
Fix wrong behavior of 'light_controllerAccessible'
This function was:
- Reading values from the controller
- Checking write permission even when we just want reading values
- Checking the mincap file instead of the actual controller
The last one is also true for other functions using
'light_getBrightness'.
This commit fixes that.
7 år sedan
Abdullah ibn Nadjo
01e73a2d3d
Fix unclosed DIR when targeting keyboard
7 år sedan
Abdullah ibn Nadjo
accee29c18
Don't check '/etc/light' folder when unnecessary
7 år sedan
Abdullah ibn Nadjo
12e81769d9
'light_isWritable' shouldn't truncate file contents
7 år sedan
Abdullah ibn Nadjo
6aea2b15bf
Improve 'if' readability
7 år sedan
Abdullah ibn Nadjo
2f14acb12e
Avoid redondant checking
7 år sedan
Abdullah ibn Nadjo
3b2835b626
Check if controller is accessible before getting value
7 år sedan
Abdullah ibn Nadjo
9f12ff92a2
Avoid checking for write permission if just getting value
7 år sedan
Fredrik Svantesson
5b302a0a92
Improve documentation, fix #24
7 år sedan
Fredrik Svantesson
674ada0528
Merge pull request #18 from ixjlyons/makefile-cleanup
Some Makefile cleanup.
7 år sedan
Fredrik Svantesson
03687e3063
Merge pull request #21 from sbmueller/keyboard
Add -k flag for keyboard backlight support
7 år sedan
Sebastian Müller
f0da610cf1
Add -k flag for keyboard backlight support
7 år sedan
Fredrik Svantesson
c4820e7d1e
Merge pull request #19 from ebfe/patch-1
Don't pretend there are info files
8 år sedan
Michael Gehring
028935a9af
Don't pretend there are info files
8 år sedan
Kenneth Lyons
88dfce9062
Some Makefile cleanup.
8 år sedan
Fredrik Haikarainen
9681c7268a
Fixes #12
8 år sedan
Fredrik Haikarainen
df77f14c02
Cleaned up README.md
8 år sedan
Fredrik Haikarainen
81678f163a
Remove deprecated .deb-package support. Closes #6
8 år sedan
Fredrik Haikarainen
b4cda334c5
Merge pull request #10 from ixjlyons/fix-mandir
Honor DESTDIR in man page installation.
8 år sedan
Kenneth Lyons
8ef51af786
Honor DESTDIR in man page installation.
8 år sedan
Fredrik Svantesson
5319f98840
Merged #9 with some additional fixes
8 år sedan
Simon Feiden
2fcbd321f2
generate a man page for light on make install
8 år sedan
Fredrik Haikarainen
075bd641ab
Update README.md
9 år sedan
Fredrik Haikarainen
77e89d1d34
Fixes #5
9 år sedan
Fredrik Haikarainen
24f6a72cdd
Do not explicitly cast void pointers from malloc
10 år sedan
Fredrik Haikarainen
78fba9dbaf
Added debian packages to README.md
10 år sedan
Fredrik Haikarainen
49edb63381
Created README.md, Removed old README
10 år sedan
Fredrik Haikarainen
8dfe104b74
Added save/restore functionality
10 år sedan
Fredrik Haikarainen
0161728ed5
Updated README
10 år sedan
Fredrik Haikarainen
deea00f712
Fixed make install
10 år sedan
Fredrik Haikarainen
9aeb800c25
Fix #3
10 år sedan
Fredrik Haikarainen
a8746f9171
Fixed missing break
10 år sedan
Fredrik Haikarainen
b60192102d
Added operationmode to list controllers (-L)
10 år sedan
Fredrik Haikarainen
cbb147b4e7
Made sure /etc directories exists
10 år sedan
Fredrik Haikarainen
056703f4d4
Added compiler optimization flags, created .gitignore
10 år sedan
Fredrik Haikarainen
7ee922c192
Fix return codes for main()
10 år sedan