Remove unnecessary quotes and semicolons

Where not required, they only add visual cruft.

src/include/build.sh

@@ -8,9 +8,9 @@ _build1() {
     #
     # Process one skeleton
     #
-    local srcpath="$1"
-    local dstpath="$2"
-    local ftype="$3"
+    local srcpath=$1
+    local dstpath=$2
+    local ftype=$3
     test -n "$dstpath"  || dstpath=${srcpath%.skel}
     test -n "$ftype"    || ftype=$(_guess_ftype "$dstpath")
     debug_var srcpath dstpath ftype
@@ -23,7 +23,7 @@ _build1_ftype() {
     #
     # Build a file of type $1
     #
-    local ftype="$1"
+    local ftype=$1
     case $ftype in
         MKIT_COMMON)    _expand_tokens "tokens" ;;
         markdown)       _expand_includes | _expand_tokens "tokens" ;;
@@ -93,7 +93,7 @@ _guess_ftype() {
     #
     # Guess file type from destination path $1
     #
-    local dstpath="$1"
+    local dstpath=$1
     case $dstpath in
         *.md) echo markdown    ;;
         *)    echo MKIT_COMMON ;;
@@ -209,8 +209,8 @@ rpmstuff() {
     #
     # Build specfile
     #
-    local specname="$MKIT_PROJ_PKGNAME.spec"
-    local specsrc="$(ini 1value "dist:rpmstuff")"
+    local specname=$MKIT_PROJ_PKGNAME.spec
+    local specsrc=$(ini 1value "dist:rpmstuff")
     test -n "$specsrc" || die "dist:rpmstuff not specified"
     test -f "$specsrc" || die "specfile template not found: $specsrc"
     _build1 "$specsrc" "$specname"

src/include/deploy.sh

@@ -23,9 +23,9 @@ _deploy_item() {
     # Directories are copied recursively, and mode is
     # applied only to files.
     #
-    local src="$1"
-    local dst="$2"
-    local mode="${3:-$MKIT_DEFAULT_MODE}"
+    local src=$1
+    local dst=$2
+    local mode=${3:-$MKIT_DEFAULT_MODE}
     if test -d "$src";
     then
         _maybe mkdir -vp "$(dirname "$dst")"
@@ -55,7 +55,7 @@ _get_root() {
     #
     # Find out target root for group $1
     #
-    local grp="$1"
+    local grp=$1
     local root=$(ini 1value "roots:$grp")
     local destdir=$(ini 1value ENV:DESTDIR)
     destdir=${destdir%/}

src/include/facts.sh

@@ -6,7 +6,7 @@ git_bool() {
     #
     # Get git bool (ie. exit status counts) $1
     #
-    local bool_name="$1"
+    local bool_name=$1
     git_present || warn "can't give bool outside git repo: $bool_name"
     case "$bool_name" in
         dirty_files)
@@ -29,7 +29,7 @@ git_fact() {
     #
     # Get git fact $1
     #
-    local fact_name="$1"
+    local fact_name=$1
     git_present || warn "can't give fact outside git repo: $fact_name"
     case "$fact_name" in
         latest_tag)
@@ -165,7 +165,7 @@ semver() {
             0:)  suffix="+dirty"         ;;
             1:*) suffix="+$commit"       ;;
             0:*) suffix="+$commit.dirty" ;;
-            *)   suffix=MKIT_BUG;
+            *)   suffix=MKIT_BUG
                  warn "MKIT_BUG: bad dirt/commit detection" ;;
         esac
         test -n "$prerl" && suffix="-$prerl$suffix"

src/include/ini.sh

@@ -48,12 +48,12 @@ _ini_greppath() {
     #     [files:share]
     #         my/lib.sh   = proj/my/lib.sh
     #
-    local wnt="$1"
-    local wntkey="${wnt##*:}"
-    local wntsec="${wnt%:$wntkey}"
+    local wnt=$1
+    local wntkey=${wnt##*:}
+    local wntsec=${wnt%:$wntkey}
     if test "$wntsec" = 'ENV';
     then
-        local override="${!wntkey}"
+        local override=${!wntkey}
         if test -n "$override";
         then
             echo "$override"
@@ -67,7 +67,7 @@ _ini_grepsec() {
     #
     # Read one INI section
     #
-    local wnt="$1"
+    local wnt=$1
     local ok=false
     grep '.' \
       | grep -v '\s*#' \
@@ -87,7 +87,7 @@ _ini_lskeys() {
     #
     # List keys from a section
     #
-    local sct="$1"
+    local sct=$1
     _ini_grepsec "$sct" | cut -d= -f1 | sort | uniq
 }
 
@@ -125,8 +125,8 @@ update_version() {
     #
     # Change project.version in mkit.ini at path $2 to version $1
     #
-    local version="$1"
-    local inifile="$2"
+    local version=$1
+    local inifile=$2
     local tmp=$(mktemp -t mkit.update_version.XXXXXXXX)
     <"$inifile" perl -e '
         my $hit = 0;

src/include/mkit.sh

@@ -66,7 +66,7 @@ _compver() {
     # the x.  Fragments must equal.
     #
     local their_ver our_x our_y their_x their_y
-    their_ver="$1"
+    their_ver=$1
     their_x=${their_ver%%.*}
     their_y=${their_ver##$their_x.}
     their_y=${their_y%%.*}

src/include/release.sh

@@ -28,7 +28,7 @@ _relck() {
     #
     # Die if blocking condition $1 is detected
     #
-    local condition="$1"
+    local condition=$1
     local x
     case "$condition" in
         git_present)
@@ -127,7 +127,7 @@ _release_msg() {
 }
 
 _vbump() {
-    local rlevel="$1"
+    local rlevel=$1
     local nextver   # after the bump
     _relck git_present
     _relck at_relsrc