Apply ShellCheck advice

dotfiles.config/Xlib/bin/setup

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-host=`hostname -s`
+host=$(hostname -s)
 
 cat<<EOF > $HOME/.Xdefaults
 !! This file is generated by .config/Xlib/bin/setup

dotfiles.config/Xlib/colorscheme/mkdemo

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-. $(ffoom path) || exit 3
+. "$(ffoom path)" || exit 3
 
 ffoo import pretty
 
@@ -18,8 +18,8 @@ xd2html() {
         test -n "$name"  || continue
         test -n "$color" || continue
         debug -v name color
-        test "$name" == "URxvt.background" && echo "$color" > $CSDEMO_BG
-        test "$name" == "URxvt.foreground" && echo "$color" > $CSDEMO_FG
+        test "$name" == "URxvt.background" && echo "$color" > "$CSDEMO_BG"
+        test "$name" == "URxvt.foreground" && echo "$color" > "$CSDEMO_FG"
         echos "        <p style='color: $color'>$name</p>"
     done
 }
@@ -43,20 +43,20 @@ css() {
     echos "body {"
     echos "    font-size: xx-large;"
     echos "    font-family: monospace;"
-    echos "    color: $(cat $CSDEMO_FG);"
-    echos "    background-color: $(cat $CSDEMO_BG);"
+    echos "    color: $(cat "$CSDEMO_FG");"
+    echos "    background-color: $(cat "$CSDEMO_BG");"
     echos "}"
 }
 
 test -n "$CSDEMO_FNAME" || usage_is "scheme.Xresources"
 
-htmlhead                    >  $CSDEMO_FNAME.html
-cat $CSDEMO_FNAME | xd2html >> $CSDEMO_FNAME.html
-htmltail                    >> $CSDEMO_FNAME.html
-debug -f $CSDEMO_FG $CSDEMO_BG
+htmlhead                 >  "$CSDEMO_FNAME.html"
+<"$CSDEMO_FNAME" xd2html >> "$CSDEMO_FNAME.html"
+htmltail                 >> "$CSDEMO_FNAME.html"
+debug -f "$CSDEMO_FG" "$CSDEMO_BG"
 test -s "$CSDEMO_FG" || die "failed to parse URxvt.foreground"
 test -s "$CSDEMO_BG" || die "failed to parse URxvt.background"
-css                         >  $CSDEMO_FNAME.css
+css                         >  "$CSDEMO_FNAME.css"
 
-rm $CSDEMO_BG
-rm $CSDEMO_FG
+rm "$CSDEMO_BG"
+rm "$CSDEMO_FG"

dotfiles/bash/setup

@@ -1,11 +1,11 @@
 #!/bin/bash
 
 put() {
-    echo "$1" >> $HOME/.bashrc
+    echo "$1" >> "$HOME/.bashrc"
 }
 
 mark="# added by https://github.com/AloisMahdal/mydots"
-if grep -qF "$mark" $HOME/.bashrc;
+if grep -qF "$mark" "$HOME/.bashrc";
 then
     echo "already set up, giving up";
     exit 1;

dotfiles/gittum/bin/findcat

@@ -1,6 +1,6 @@
 #!/bin/sh
 
 NAME=$1
-cat .git_$NAME 2>/dev/null \
-    || cat .git/gittum/$NAME 2>/dev/null \
-    || cat ~/.gittum/default/$NAME 2>/dev/null
+cat ".git_$NAME" 2>/dev/null \
+    || cat ".git/gittum/$NAME" 2>/dev/null \
+    || cat "$HOME/.gittum/default/$NAME" 2>/dev/null

dotfiles/gittum/bin/setup

@@ -1,23 +1,24 @@
 #!/bin/bash
 
-git_binary=`which git`
-
-if [[ -x $HOME/bin/git ]]; then
-    git_binary=$HOME/bin/git
-fi
-
-gitver=`$git_binary --version | cut -d ' ' -f 3`
-if [[ "$gitver" > "1.8" ]]; then
+git_binary=$(which git)
+if [[ -x "$HOME/bin/git" ]]; then
+    git_binary="$HOME/bin/git"
+gitver=$(git --version | cut -d ' ' -f 3)
+if [[ "x$gitver" > "x1.8" ]]; then
     tilde='~'
 else
     tilde=$HOME
 fi
 
-host=`hostname -s`
-user=`whoami`
+host=$(hostname -s)
+user=$(whoami)
+
+mkconfig() {
+    echo "[include]"
+    echo "    path = $tilde/.gittum/main.gitconfig"
+    echo "    path = $tilde/.gittum/host/$host.gitconfig"
+    echo "    path = $tilde/.gittum/user/$user.gitconfig"
+    echo "    path = $tilde/.gittum/private.gitconfig"
+}
 
-printf "[include]\n" >> ~/.gitconfig
-printf "    path = $tilde/.gittum/main.gitconfig\n" >> ~/.gitconfig
-printf "    path = $tilde/.gittum/host/$host.gitconfig\n" >> ~/.gitconfig
-printf "    path = $tilde/.gittum/user/$user.gitconfig\n" >> ~/.gitconfig
-printf "    path = $tilde/.gittum/private.gitconfig\n" >> ~/.gitconfig
+mkconfig >>"$HOME/.gitconfig"

dotfiles/gittum/bin/sibling

@@ -32,7 +32,7 @@ die() {
 }
 
 usage() {
-    echo "usage: git $(basename $0) [-v] [-s SIBLING] [-r REMOTE] PROJECT"
+    echo "usage: git $(basename "$0") [-v] [-s SIBLING] [-r REMOTE] PROJECT"
     exit 0
 }
 
@@ -55,7 +55,6 @@ think() {
 ## initz
 #
 
-origin_name="origin"
 sibling_conf=".gittum-sibling"
 verbose=false
 sibling=$(find -maxdepth 1 -type d -name "[^.]*" | sort | head -1)
@@ -80,10 +79,10 @@ test -d "$sibling" || die "sibling does not exist: $sibling"
 #
 
 pushd "$sibling" >/dev/null
-new_remote=$(rewrite_uri $remote_name $project)
+new_remote=$(rewrite_uri "$remote_name" "$project")
 popd >/dev/null
 
 test -n "$new_remote" || die "no such remote at sibling: $new_remote at $sibling"
 
 think \'git clone $new_remote\'
-git clone $new_remote
+git clone "$new_remote"