Fix the easier code smells

sznqalibs/hoover.py

@@ -77,7 +77,6 @@ def regression_test(argsrc, tests, driver_settings, cleanup_hack=None,
                 aclass.check_values(argset)
             except NotImplementedError:         # let them bail out
                 counter.count_for(aclass, 'bailouts')
-                pass
             else:
                 data[aclass], duration, overhead = get_data_and_stats(
                     aclass, argset, driver_settings)
@@ -156,7 +155,7 @@ def get_data(driverClass, argset, driver_settings):
 # ## The Pattern                                                           ## #
 # ########################################################################### #
 
-class _BaseRuleOp():
+class _BaseRuleOp(object):
 
     def __init__(self, items, item_ok):
         self._items = items
@@ -175,7 +174,7 @@ class _BaseRuleOp():
             raise ValueError("items must be an iterable: %r" % self._items)
 
 
-class RuleOp():
+class RuleOp(object):
 
     class ALL(_BaseRuleOp):
 
@@ -218,7 +217,7 @@ class RuleOp():
 # ## The Path                                                              ## #
 # ########################################################################### #
 
-class DictPath():
+class DictPath(object):
     """Mixin that adds "path-like" behavior to the top dict of dicts.
 
     Use this class as a mixin for a deep dic-like structure and you can access
@@ -245,7 +244,7 @@ class DictPath():
 
     DIV = "/"
 
-    class Path():
+    class Path(object):
 
         def __init__(self, path, div):
             self.DIV = div
@@ -476,14 +475,14 @@ class TinyCase(dict, DictPath):
     def hack(self, ruleset):
         """Apply action from each rule, if patterns match."""
 
-        def driver_matches():
+        def driver_matches(rule):
             if 'drivers' not in rule:
                 return True
             else:
                 return any(dataMatch(p, self)
                            for p in rule['drivers'])
 
-        def argset_matches():
+        def argset_matches(rule):
             if 'argsets' not in rule:
                 return True
             else:
@@ -493,7 +492,7 @@ class TinyCase(dict, DictPath):
         matched = False
         cls = self.__class__
         for rule in ruleset:
-            if driver_matches() and argset_matches():
+            if driver_matches(rule) and argset_matches(rule):
                 matched = True
                 for action_name in cls.known_actions:
                     if action_name in rule:
@@ -999,7 +998,7 @@ class Tracker(dict):
 
         def get_all_colnames():
             cn = {}
-            for errstr, affected in self._db.iteritems():
+            for affected in self._db.itervalues():
                 for argset in affected:
                     cn.update(dict.fromkeys(argset.keys()))
                 return sorted(cn.keys())