Solve or mute last ShellCheck issues

src/bin/sfdoc

@@ -1,4 +1,5 @@
 #!/bin/bash
+#shellcheck disable=SC1090
 
 . "$(sfpath)" || exit 3
 

src/bin/sfembed

@@ -1,4 +1,5 @@
 #!/bin/bash
+#shellcheck disable=SC1090
 
 . "$(sfpath)" || exit 3
 
@@ -41,6 +42,7 @@ mkmodules() {
     (
         SHELLFU_EMBEDTMP="$modlist" "$ScriptFullPath" >&2
     )
+    #shellcheck disable=SC2030
     awk '!x[$0]++' "$modlist" \
       | while read -r Module;
         do
@@ -60,6 +62,7 @@ mkfoot() {
     echo "#"
 }
 
+#shellcheck disable=SC2031
 mkmodule() {
     #
     # Print single module body
@@ -110,6 +113,7 @@ do_embed() {
 
 main() {
     local Script        # script to embed libraries into
+    #shellcheck disable=SC2034
     while true; do case "$1" in
         -d) PRETTY_DEBUG=true; shift ;;
         -v) PRETTY_VERBOSE=true; shift ;;

src/include-bash/_pretty_color.sh

@@ -24,6 +24,8 @@ __shellfu__pretty_color__init() {
 
 _pretty__debug() {
     local decor="()"
+    local caller_is_main=${caller_is_main:-false}
+    local caller=${caller:-UNKNOWN}
     $caller_is_main && decor=
     while IFS= read -r line;
     do echo -ne "${_PRETTY_COLOR_DEBUG}debug:$caller$decor:$_PRETTY_COLOR_OFF"

src/include-bash/_pretty_html.sh

@@ -3,6 +3,8 @@
 
 _pretty__debug() {
     local class=caller_fn
+    local caller_is_main=${caller_is_main:-false}
+    local caller=${caller:-UNKNOWN}
     $caller_is_main && class=caller_bin
     echo -n "<pre class='debug'><span class='$class'>$caller</span>"
     cat

src/include-bash/_pretty_journald.sh

@@ -3,6 +3,8 @@
 
 _pretty__debug() {
     local decor="()"
+    local caller_is_main=${caller_is_main:-false}
+    local caller=${caller:-UNKNOWN}
     $caller_is_main && decor=
     sed "s/^/debug:$caller$decor: /" | systemd-cat -p debug -t "${0##*/}"
 }

src/include-bash/_pretty_notify.sh

@@ -3,6 +3,8 @@
 
 _pretty__debug() {
     local decor="()"
+    local caller_is_main=${caller_is_main:-false}
+    local caller=${caller:-UNKNOWN}
     $caller_is_main && decor=
     notify-send -u low -a "${0##*/}" debug "debug:$caller$decor: $(cat)"
 }

src/include-bash/_pretty_plain.sh

@@ -3,6 +3,8 @@
 
 _pretty__debug() {
     local decor="()"
+    local caller_is_main=${caller_is_main:-false}
+    local caller=${caller:-UNKNOWN}
     $caller_is_main && decor=
     while IFS= read -r line;
     do echo "debug:$caller$decor: $line"; done

src/include-bash/pretty.sh

@@ -350,8 +350,9 @@ _pretty__echo() {
     local caller_is_main    # true if caller was main script or main() in it
     local provider          # which provider (_pretty__echo_*()) to use
     frontend="$(_pretty__get_frontend)" || exit_usage
-    read caller_nidx caller <<<$(_pretty__get_caller)
+    read -r caller_nidx caller <<<"$(_pretty__get_caller)"
     test "$frontend" = debug && _pretty__is_excluded "$caller" && return 0
+    #shellcheck disable=SC2034
     case $caller_nidx:$caller in
         0:*)        caller_is_main=true; caller="${0##*/}" ;;
         1:main)     caller_is_main=true; caller="${0##*/}" ;;
@@ -543,6 +544,7 @@ _pretty__is_word() {
     # Check if $1 contains only alphanumeric chars or _
     #
     local tainted="$1"
-    local clean=$(tr -c -d '_[:alnum:]' <<< "$tainted")
+    local clean
+    clean=$(tr -c -d '_[:alnum:]' <<< "$tainted")
     test "$tainted" = "$clean"
 }

src/include-sh/charmenu.sh

@@ -1,4 +1,5 @@
 #!/bin/sh
+#shellcheck disable=SC2039
 
 
 CHARMENU_FILE="${CHARMENU_FILE:-}"

src/include-sh/mdfmt.sh

@@ -1,4 +1,5 @@
 #!/bin/sh
+#shellcheck disable=SC2039
 
 #
 # mdfmt - Markdown formatted output from your shell scripts

src/include-sh/termcolors.sh

@@ -1,4 +1,5 @@
 #!/bin/sh
+#shellcheck disable=SC2034
 
 #
 # Color definitions