Apply changes suggested by ShellCheck (mkit)

utils/mkit/include/build.sh

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-. $MKIT_DIR/include/ini.sh || die "cannot import ini.sh"
+. "$MKIT_DIR/include/ini.sh" || die "cannot import ini.sh"
 
 
 build() {
@@ -23,15 +23,10 @@ build1() {
     srcpath=$1
     dstpath=${srcpath%.skel}
     case $dstpath in
-        *.md)   cat $srcpath \
-                  | expand_includes \
-                  | expand_variables \
-                > $dstpath ;;
-        *)      cat $srcpath \
-                  | expand_variables \
-                > $dstpath ;;
+        *.md) <"$srcpath" expand_includes | expand_variables >"$dstpath" ;;
+        *)    <"$srcpath"                   expand_variables >"$dstpath" ;;
     esac
-    echo $dstpath >> built.list
+    echo "$dstpath" >> built.list
 }
 
 build_manpages() {
@@ -41,9 +36,9 @@ build_manpages() {
         ini lskeys "files:man" \
           | while read manfile;
             do
-                mdfile=$manfile.md
-                ronn -r $mdfile
-                echo $manfile >> built.list
+                mdfile="$manfile.md"
+                ronn -r "$mdfile"
+                echo "$manfile" >> built.list
             done
     else
         echo "ronn is not installed"
@@ -56,9 +51,10 @@ clean() {
     # Clean up tree after building
     #
     test -f built.list && {
-        cat built.list | xargs rm -f
+        <built.list xargs rm -f
         rm -f built.list
-    } || :
+    }
+    true
 }
 
 dist() {
@@ -67,13 +63,13 @@ dist() {
     #
     local version=$(get_version)
     local dirname=$MKIT_PKGNAME-$version
-    mkdir -p $dirname
+    mkdir -p "$dirname"
     local item
-    cp -R $(ini values "lists:dist") $dirname
-    sed -i -e "s/^VERSION = .*/VERSION = $version/" $dirname/config.mk
-    tar -cf $dirname.tar $dirname
-    gzip $dirname.tar
-    rm -rf $dirname
+    cp -R "$(ini values "lists:dist")" "$dirname"
+    sed -i -e "s/^VERSION = .*/VERSION = $version/" "$dirname/config.mk"
+    tar -cf "$dirname.tar" "$dirname"
+    gzip "$dirname.tar"
+    rm -rf "$dirname"
 }
 
 expand_includes() {
@@ -111,12 +107,12 @@ expand_variables() {
       | while read varname;
         do
             varvalue="$(ini 1value "vars:$varname" | sed -e 's/\$/\\$/' )"
-            echo "s|$varname|$varvalue|;" >> $script
+            echo "s|$varname|$varvalue|;" >> "$script"
         done
-    echo "s|__CODENAME__|$CODENAME|;"     >> $script
-    echo "s|__VERSION__|$(get_version)|;" >> $script
-    perl -wp $script
-    rm $script
+    echo "s|__CODENAME__|$CODENAME|;"     >> "$script"
+    echo "s|__VERSION__|$(get_version)|;" >> "$script"
+    perl -wp "$script"
+    rm "$script"
 }
 
 get_version() {
@@ -182,14 +178,14 @@ get_version() {
         fi
         test -n "$lasttag" && version=${lasttag:1}
         local suffix=""
-        case $commit:$dirty in
+        case "$commit:$dirty" in
             :)       suffix=""                ;;
             :dirty)  suffix="+$dirty"         ;;
             *:)      suffix="+$commit"        ;;
             *:dirty) suffix="+$commit.$dirty" ;;
         esac
         test -b "$prerl" && suffix="-$prerl$suffix"
-        version=$version$suffix
+        version="$version$suffix"
     fi
-    echo $version
+    echo "$version"
 }

utils/mkit/include/deploy.sh

@@ -34,13 +34,13 @@ deploy_item() {
     #
     local src="$1"
     local dst="$2"
-    local mode=${3:-$MKIT_DEFAULT_MODE}
+    local mode="${3:-$MKIT_DEFAULT_MODE}"
     if test -d "$src";
     then
         cp -vr "$src" "$dst"
-        find "$dst" -type f | xargs chmod -c "$mode"
+        find "$dst" -type f -print0 | xargs -0 chmod -c "$mode"
     else
-        command -p install -DTvm $mode $src "$dst"
+        command -p install -DTvm "$mode" "$src" "$dst"
     fi
 }
 
@@ -50,7 +50,7 @@ get_dst() {
     #
     local grp=$1
     local src=$2
-    echo "$(get_root $grp)/$(ini 1value "files:$grp:$src")"
+    echo "$(get_root "$grp")/$(ini 1value "files:$grp:$src")"
 }
 
 get_root() {
@@ -77,10 +77,11 @@ install() {
               | while read src;
                 do
                     dst=$(get_dst "$group" "$src")
-                    deploy_item "$src" "$dst" $mode
+                    deploy_item "$src" "$dst" "$mode"
                 done
         done
-    test -f .autoclean && clean || :
+    test -f .autoclean && clean
+    true
 }
 
 uninstall() {

utils/mkit/include/ini.sh

@@ -15,7 +15,7 @@ ini() {
         1value) fn=_ini_greppath; limit="tail -1" ;;
         *)      die "incorrect use of \`ini()\`"
     esac
-    cat $MKIT_INI | $fn $arg | $limit
+    <"$MKIT_INI" $fn "$arg" | $limit
 }
 
 _ini_cat() {
@@ -66,9 +66,9 @@ _ini_greppath() {
     #     [files:share]
     #         my/lib.sh   = proj/my/lib.sh
     #
-    local wnt=$1
-    local wntkey=${wnt##*:}
-    local wntsec=${wnt%:$wntkey}
+    local wnt="$1"
+    local wntkey="${wnt##*:}"
+    local wntsec="${wnt%:$wntkey}"
     if test "$wntsec" = 'ENV';
     then
         local override="${!wntkey}"
@@ -78,14 +78,14 @@ _ini_greppath() {
             return
         fi
     fi
-    _ini_grepsec $wntsec | _ini_grepkey $wntkey
+    _ini_grepsec "$wntsec" | _ini_grepkey "$wntkey"
 }
 
 _ini_grepsec() {
     #
     # Read one INI section
     #
-    local wnt=$1
+    local wnt="$1"
     local ok=false
     grep '.' \
       | grep -v '\s*#' \
@@ -105,17 +105,17 @@ _ini_lskeys() {
     #
     # List keys from a section
     #
-    local sct=$1
-    _ini_grepsec $sct | cut -d= -f1 | sort | uniq
+    local sct="$1"
+    _ini_grepsec "$sct" | cut -d= -f1 | sort | uniq
 }
 
 _ini_maybe_expand() {
     #
     # Decide whether or not to expand
     #
-    if test $MKIT_INI_EXPAND -gt 0;
+    if test "$MKIT_INI_EXPAND" -gt 0;
     then
-        MKIT_INI_EXPAND=$(( $MKIT_INI_EXPAND - 1 )) _ini_expand
+        MKIT_INI_EXPAND=$(( --MKIT_INI_EXPAND )) _ini_expand
     else
         _ini_cat
     fi

utils/mkit/include/mkit.sh

@@ -1,9 +1,9 @@
 #!/bin/bash
 
-. $MKIT_DIR/include/build.sh  || die "cannot import build.sh"
-. $MKIT_DIR/include/deploy.sh || die "cannot import deploy.sh"
-. $MKIT_DIR/include/release.sh || die "cannot import release.sh"
-. $MKIT_DIR/include/ini.sh    || die "cannot import ini.sh"
+. "$MKIT_DIR/include/build.sh"  || die "cannot import build.sh"
+. "$MKIT_DIR/include/deploy.sh" || die "cannot import deploy.sh"
+. "$MKIT_DIR/include/release.sh" || die "cannot import release.sh"
+. "$MKIT_DIR/include/ini.sh"    || die "cannot import ini.sh"
 
 MKIT_INI=${MKIT_INI:-mkit.ini}
 MKIT_INI_EXPAND=2
@@ -19,16 +19,16 @@ mkit_init() {
     #
     test -f "$MKIT_INI" || die "cannot find mkit.ini: $MKIT_INI"
     tmp=$(mktemp)
-    sed -e 's/ = /=/' < config.mk > $tmp
-    . $tmp
-    rm -f $tmp
+    sed -e 's/ = /=/' < config.mk > "$tmp"
+    . "$tmp"
+    rm -f "$tmp"
 }
 
 die() {
     #
     # Exit with message and non-zero exit status
     #
-    echo "fatal: $@" >&2
+    echo "fatal: $*" >&2
     exit 4
 }
 
@@ -48,6 +48,6 @@ route() {
             $1
             ;;
         *)
-            echo "usage: $(basename $0) build|clean|dist|install|uninstall" >&2
+            echo "usage: $(basename "$0") build|clean|dist|install|uninstall" >&2
     esac
 }

utils/mkit/include/release.sh

@@ -13,7 +13,7 @@ __make_ver() {
         z) new="$oldx.$oldy.$((oldz+1))"    ;;
         *) die "invalid release level: $1"  ;;
     esac
-    echo $new
+    echo "$new"
 }
 
 __release() {
@@ -30,11 +30,11 @@ __release() {
     git rev-parse HEAD >&/dev/null || die "cannot release outside git repo"
     local lastfile=$(git diff-tree --no-commit-id --name-only -r HEAD)
     local lasttag=$(git tag | grep ^v | sort -V | tail -n1)
-    local changelog="$(git log --oneline $lasttag..HEAD)"
+    local changelog="$(git log --oneline "$lasttag..HEAD")"
     local curbranch=$(git rev-parse --abbrev-ref HEAD)
     local dirt="$(git diff --shortstat 2>/dev/null)"
 
-    local newver=$(__make_ver $level ${lasttag#v})
+    local newver=$(__make_ver "$level" "${lasttag#v}")
     local newtag=v$newver
     local higher=$(echo -e "$oldtag\n$newtag" | sort -V | tail -n1)
 
@@ -62,8 +62,8 @@ __release() {
     # FIXME: Have user prepare proper message with changelog
 
     set -e
-    git tag -m "$MKIT_PROJNAME $newtag - $CODENAME" $newtag
-    git branch -f $RELDST $newtag
+    git tag -m "$MKIT_PROJNAME $newtag - $CODENAME" "$newtag"
+    git branch -f "$RELDST" "$newtag"
 }
 
 release_x() {

utils/mkit/make

@@ -8,7 +8,7 @@ die() {
 
 export MKIT_DIR=${MKIT_DIR:-mkit}
 
-. $MKIT_DIR/include/mkit.sh || die "failed to init; check if MKIT_DIR is set properly: $MKIT_DIR"
+. "$MKIT_DIR/include/mkit.sh" || die "failed to init; check if MKIT_DIR is set properly: $MKIT_DIR"
 
 mkit_init